fix: Update push_data annotation with JsonSerializable instead of Any#899
Open
Mantisus wants to merge 5 commits into
Open
fix: Update push_data annotation with JsonSerializable instead of Any#899Mantisus wants to merge 5 commits into
push_data annotation with JsonSerializable instead of Any#899Mantisus wants to merge 5 commits into
Conversation
Collaborator
Author
|
@vdusek, well, it caused issues, and we should update the SDK typing after Crawlee is updated. |
Mantisus
changed the title
push_data annotation with JsonSerializable instead of Any
Contributor
|
Hi @Mantisus , could you please make this ready for a review? Let's release a patch of Crawlee, and the last patch of SDK, and then jump into BCs for SDK v4 🙂 . |
Collaborator
Author
It's ready, but we need to release the crawlee patch first so I can unlink it from the master branch. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up: apify/crawlee-python#1889